[codex] Coerce stringified spawn agent params#658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds narrow coercion for spawn-agent
paramsvalues when models emit a valid JSON object as a string. This covers both batchedspawn_agentsentries andspawn_agent_inline, while leaving malformed strings, arrays, and primitives to fail normal schema validation.Also updates Freebuff e2e tests to use
execFileSyncinstead of shell-quotedexecSyncfor simple binary flag checks.Why
Some providers can produce nested agent params as a JSON string even when the top-level tool call input is otherwise valid. That caused validation failures before the agent-specific params schema could run.
Validation
bun test common/src/tools/params/__tests__/coerce-to-array.test.tsbun test packages/agent-runtime/src/__tests__/tool-validation-error.test.tsbun run typecheckincommon/bun run typecheckinpackages/agent-runtime/git diff --checkNote: Freebuff e2e tests were not run because
cli/bin/freebuffis not present in this workspace.